All semaphor all the time #8755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scbedd
changed the title
scbedd
changed the title
mikeharder
approved these changes
Aug 1, 2024
There was a problem hiding this comment.
I agree this is better than synchronous locking. You generally want to use async as much as possible inside asp.net apps.
However, it is still susceptible to deadlocks and/or race conditions, if we don't have the locking semantics/ordering exactly correct. So if this doesn't fix all the issues, we might need to take a closer look at the algorithms we are using,.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cuts out all
lockusage forawait SemaphorSlim.WaitAsync()to synchronize resource access.Originally, we had 3 possible locks
This moves to using a semaphore for these. Unfortunately this has the impact of forcing
asyncin a lot of places that didn't use it before, so I've got some test pain to resolve as a result.@mikeharder I'm very pleased with this one!