Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add azure-sdk-for-rust to utility pipelines #8737

Merged
merged 2 commits into from
Oct 23, 2024
Merged

Conversation

hallipr
Copy link
Member

@hallipr hallipr commented Jul 31, 2024

No description provided.

@hallipr hallipr requested a review from a team as a code owner July 31, 2024 20:41
Copy link
Member

@weshaggard weshaggard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets hold on this until the eng\common changes hit the main branch in the rust repo.

Copy link

github-actions bot commented Oct 4, 2024

Hi @hallipr. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.

@github-actions github-actions bot added the no-recent-activity There has been no recent activity on this issue. label Oct 4, 2024
Copy link

Hi @hallipr. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing /reopen if you'd like to continue working on these changes. Please be sure to use the command to reopen or remove the no-recent-activity label; otherwise, this is likely to be closed again with the next cleanup pass.

@github-actions github-actions bot closed this Oct 11, 2024
@hallipr hallipr reopened this Oct 21, 2024
@github-actions github-actions bot removed the no-recent-activity There has been no recent activity on this issue. label Oct 21, 2024
@hallipr hallipr force-pushed the users/pahallis/rust-onboard branch from 88d8436 to 77b9b51 Compare October 21, 2024 17:38
@hallipr hallipr requested a review from weshaggard October 21, 2024 17:39
Copy link
Member

@RickWinter RickWinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@weshaggard Do you still have requested changes?

@weshaggard weshaggard dismissed their stale review October 21, 2024 18:38

unblocked now.

@weshaggard
Copy link
Member

@hallipr please add rust to https://github.com/Azure/azure-sdk-tools/blob/main/eng/pipelines/eng-workflows-sync.yml as well so the workflows sync also. After this PR gets merged then do a sync.

Copy link
Member

@weshaggard weshaggard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add to workflow sync too.

@hallipr
Copy link
Member Author

hallipr commented Oct 23, 2024

/check-enforcer override

@hallipr hallipr merged commit f4965c2 into main Oct 23, 2024
4 checks passed
@hallipr hallipr deleted the users/pahallis/rust-onboard branch October 23, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants