Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Documentation Issues during Diff #8733

Merged
merged 2 commits into from
Jul 31, 2024

Conversation

chidozieononiwu
Copy link
Member

@chidozieononiwu chidozieononiwu commented Jul 31, 2024

  • Refactor related models in to different files.
  • Update Diffing logic so that it does not show nodes or tree with diff in only docs when documentation is not enabled.
  • Add a message on the page when there is no diff between the revisions being compared.

Copy link
Member

@benbp benbp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor suggestions but LGTM

@chidozieononiwu chidozieononiwu force-pushed the 073024.01/DocsAndDiff branch from 9818ce7 to 5df646a Compare July 31, 2024 23:05
@chidozieononiwu chidozieononiwu merged commit c9853b6 into Azure:main Jul 31, 2024
8 checks passed
@maririos maririos mentioned this pull request Aug 5, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants