071624.05/api revisions #8655
Merged
071624.05/api revisions #8655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
chidozieononiwu
commented
Jul 18, 2024
chidozieononiwu
commented
- This adds API-Revision view showing API Revision in detail, and ability to add APIRevisions from the review page.
|
@chidozieononiwu I see an issue. I deployed this change to staging to verify the changes. I see the comments button on left side panel but click on the conversations icon is not doing anything. |
praveenkuttappan
requested changes
Jul 18, 2024
|
I have also found a bug in the revisions page when adding a new revision. Newly added revision is not shown in the revision list without refreshing the whole page. We need to refresh the revisions automatically when a new revision is available. It's not a good user experience to ask user to refresh the page to get newly added revision. |
chidozieononiwu
force-pushed
the
071624.05/APIRevisions
branch
from
d9e1e15 to
43b4451
Compare
praveenkuttappan
approved these changes
Jul 18, 2024
WhitShake
pushed a commit
to WhitShake/azure-sdk-tools
that referenced
this pull request
Jul 24, 2024
* Add APIRevision to Review Page * Add APIRevisions list to Review Page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.