Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tsp-client] Add autorest and plugins as dependencies #8610

Merged
merged 20 commits into from
Jul 16, 2024
Merged

[tsp-client] Add autorest and plugins as dependencies #8610

merged 20 commits into from
Jul 16, 2024

Conversation

mikeharder
Copy link
Member

@mikeharder mikeharder commented Jul 11, 2024 •
edited
Loading

  • Guarantees versions of autorest and plugins are pinned after tsp-client is installed
  • Allows consumers to use standard npm commands to manage autorest and plugin versions

@catalinaperalta catalinaperalta requested a review from joheredi July 11, 2024 23:48
@catalinaperalta catalinaperalta self-requested a review July 11, 2024 23:52
@mikeharder mikeharder changed the title [tsp-client] Add autorest and openapi-to-typespec as deps [tsp-client] Add autorest and plugins as dependencies Jul 12, 2024
@mikeharder mikeharder marked this pull request as ready for review July 12, 2024 03:20
@mikeharder mikeharder self-assigned this Jul 12, 2024
catalinaperalta
catalinaperalta approved these changes Jul 12, 2024
View reviewed changes
Copy link
Member

@catalinaperalta catalinaperalta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also update the changelog to mention that we are pinning these dependencies now?

@mikeharder mikeharder marked this pull request as draft July 12, 2024 20:35
@mikeharder
Copy link
Member Author

Can we also update the changelog to mention that we are pinning these dependencies now?

I will do this before merging

@mikeharder mikeharder marked this pull request as ready for review July 16, 2024 00:06
@mikeharder
Copy link
Member Author

/azp run

@mikeharder mikeharder closed this Jul 16, 2024
@mikeharder mikeharder reopened this Jul 16, 2024
@mikeharder
Copy link
Member Author

/azp run

@azure-pipelines Azure Pipelines
Copy link

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

@mikeharder
Copy link
Member Author

/azp run tools - tsp-client - ci

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mikeharder mikeharder mentioned this pull request Jul 16, 2024
Merged
@mikeharder mikeharder merged commit f5d5955 into Azure:main Jul 16, 2024
9 checks passed
@mikeharder mikeharder deleted the tsp-client-deps branch July 16, 2024 00:43
@mikeharder mikeharder mentioned this pull request Sep 25, 2024
Merged
@maorleger maorleger mentioned this pull request Feb 4, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joheredi joheredi joheredi approved these changes

@pshao25 pshao25 pshao25 left review comments

@catalinaperalta catalinaperalta catalinaperalta approved these changes

Assignees

@mikeharder mikeharder

Labels
None yet
Projects
Azure SDK EngSys 🤖🧠
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mikeharder @catalinaperalta @joheredi @pshao25