-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set storage account test resources to disable blob public access. Disable network firewall. #8598
Conversation
The following pipelines have been queued for testing: |
The following pipelines have been queued for testing: |
fa94a37
to
d096083
Compare
The following pipelines have been queued for testing: |
The following pipelines have been queued for testing: |
36877b6
to
75fc17e
Compare
The following pipelines have been queued for testing: |
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#8598 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) --------- Co-authored-by: Ben Broderick Phillips <[email protected]>
This will disable this by default as an override.
There are several places where we have this marked as
true
in live test ARM templates, but I'm not convinced those are necessary. Will do testing against these changes before merging.EDIT: Also removing the pieces that add the network firewall by default on resource creation. This is causing a whole host of issues that we aren't getting much value from, and aren't required to do in the near term.