Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set storage account test resources to disable blob public access. Disable network firewall. #8598

Merged
merged 4 commits into from
Jul 12, 2024

Conversation

benbp
Copy link
Member

@benbp benbp commented Jul 10, 2024

This will disable this by default as an override.

There are several places where we have this marked as true in live test ARM templates, but I'm not convinced those are necessary. Will do testing against these changes before merging.

EDIT: Also removing the pieces that add the network firewall by default on resource creation. This is causing a whole host of issues that we aren't getting much value from, and aren't required to do in the near term.

@benbp benbp added the Central-EngSys This issue is owned by the Engineering System team. label Jul 10, 2024
@benbp benbp requested review from weshaggard and mikeharder July 10, 2024 18:42
@benbp benbp self-assigned this Jul 10, 2024
@benbp benbp requested a review from a team as a code owner July 10, 2024 18:42
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@benbp benbp force-pushed the benbp/storage-blob-private branch from fa94a37 to d096083 Compare July 11, 2024 18:07
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@benbp benbp changed the title Set storage account test resources to disable blob public access Set storage account test resources to disable blob public access. Disable network firewall. Jul 12, 2024
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@benbp benbp force-pushed the benbp/storage-blob-private branch from 36877b6 to 75fc17e Compare July 12, 2024 19:42
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

azure-sdk added a commit to Azure/azure-sdk-for-js that referenced this pull request Jul 12, 2024
Sync eng/common directory with azure-sdk-tools for PR
Azure/azure-sdk-tools#8598 See [eng/common
workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow)

---------

Co-authored-by: Ben Broderick Phillips <[email protected]>
@benbp benbp merged commit 58b45e1 into main Jul 12, 2024
12 checks passed
@benbp benbp deleted the benbp/storage-blob-private branch July 12, 2024 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Central-EngSys This issue is owned by the Engineering System team.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants