Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support storage network access and worm removal in remove test resources script #8558

Merged
merged 5 commits into from
Jul 8, 2024

Conversation

benbp
Copy link
Member

@benbp benbp commented Jul 3, 2024

We need to be running worm removal on storage accounts in the pipeline to avoid resource build-ups for our async cleanup script. Additionally, sometimes the network access rules we apply fail on the backend due to RP throttling. In those cases we can't disable WORM because the network policy is set to Deny, meaning blob's can't be deleted (pre-req for WORM disablement). This change includes updating the network policy within the remove script to prevent these issues as a failsafe.

@benbp benbp requested a review from a team as a code owner July 3, 2024 21:34
@benbp benbp added the Central-EngSys This issue is owned by the Engineering System team. label Jul 3, 2024
@benbp benbp self-assigned this Jul 3, 2024
@benbp benbp requested a review from weshaggard July 3, 2024 21:34
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@benbp benbp force-pushed the benbp/test-resources-subnet branch 3 times, most recently from 16a7a95 to 2e188d6 Compare July 3, 2024 23:52
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@benbp benbp force-pushed the benbp/test-resources-subnet branch from 2e188d6 to efa223b Compare July 4, 2024 00:08
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Central-EngSys This issue is owned by the Engineering System team.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants