Node Publishing Update #8496
Merged
Node Publishing Update #8496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e tags script. (going to go to semver usage before this pr merges)
scbedd
requested review from
catalinaperalta,
mikeharder,
benbp,
raych1,
tadelesh,
qiaozha,
MaryGao and
a team
as code owners
weshaggard
reviewed
Jun 24, 2024
tools/test-proxy/Azure.Sdk.Tools.TestProxy/Properties/launchSettings.json
Outdated
Show resolved
Hide resolved
weshaggard
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like when I tested an actual release, I tested the only case that would actually work when merging #8460
@catalinaperalta hit issues this past Friday with this as a result. I unblocked her, but wanted to make an adjustment to re-use the
SemVerpackage before merging.Unfortunately, it looks like if I use
SemVer, it marks packages < 1.0.0 (even if if GA-marked) asPrerelease. While I agree with this for our production packages, our internal tooling conflicts with this bar.Specifically, the typespec-emitter
latestversion is0.4.8. If we usedSemVerandIsPrereleaseproperty to determine whether to setlatestorbetatag, we would erroneously mark the latest version oftypespec-emitterwithbeta. At least until 1.0.0. For now I'm leaving the simple tag check in place.