Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix high sev security issue" #8480

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Conversation

weshaggard
Copy link
Member

Reverts #8471

@wanlwanl @raych1 @qiaozha I had to revert this as it is breaking a number of pipelines that aren't setup to correctly sync submodules. We should not be using submodules in our repos because a number of these issues.

@weshaggard weshaggard requested review from qiaozha, MaryGao and a team as code owners June 20, 2024 19:40
@scbedd
Copy link
Member

scbedd commented Jun 20, 2024

I've spent the past 30 minutes attempting to debug my weird SDL code 128 errors on exactly this. Look like this for more examples.

@weshaggard weshaggard merged commit ed34354 into main Jun 20, 2024
13 checks passed
@weshaggard weshaggard deleted the revert-8471-wanl/fix-sec-issue branch June 20, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants