-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix high sev security issue #8471
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
7bb308a
fix sec issue
wanlwanl f8fc25a
add source code it to fix security issue (pkg no maintenance
wanlwanl e140221
audit fix
wanlwanl 2b6762d
add owner
wanlwanl c62d7bc
change submodule
wanlwanl 50e139e
remove npm pkg
wanlwanl 8fa7042
update
wanlwanl 844c873
Removed submodule tools/js-sdk-release-tools/deps/azure-js-dev-tools
wanlwanl d01e1ee
fix
wanlwanl d8485a7
+owner
wanlwanl 307bd37
update
wanlwanl 7f5aa1d
remove owner
wanlwanl File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| [submodule "tools/js-sdk-release-tools/deps/azure-js-dev-tools"] | ||
| path = tools/js-sdk-release-tools/deps/azure-js-dev-tools | ||
| url = https://github.com/ts-common/azure-js-dev-tools | ||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Submodule azure-js-dev-tools
added at
d77148
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we using a submodule? Submodules cause all sorts of issues and we generally avoid them. If you need this dependency then we should publish the package instead of using a submodule.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One example of such an issue https://github.com/Azure/azure-sdk-tools/security/dependabot/178/update-logs/370202889
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @weshaggard for checking it and kindly share the guidance.
Previous tool owner used a package https://www.npmjs.com/package/@ts-common/azure-js-dev-tools
but looks like no one maintain it any more, latest version still has the same security issue. So I add submodule to update the braces package. We will definitely avoid to use packages out of maintainence in the future.
No worries, I'll downgrade the package to resolve security issue.