Adjustment to breaking docker manifest change #8430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the specific formatting
scbedd
commented
Jun 18, 2024
tools/test-proxy/Azure.Sdk.Tools.TestProxy/Common/ContentTypeUtilities.cs
Outdated
Show resolved
Hide resolved
…tilities.cs remove erroneously added include
… DONT want to see
…ure-sdk-tools into feature/add-manifest-v1
benbp
approved these changes
Jun 19, 2024
|
/check-enforcer override I don't know how I cancelled that job but I did. |
This was referenced Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #8325
We added a test case, but it turns out there is another value that also indicates a manifest. header:
application/vnd.oci.image.index.v1indicates a body containing multiple manifests. All of this needs to be stored exactly as what comes, so pretty json printing is right out.Continuing to dig via investigation usinggosdk/containers/azcontainerregistry/client_test.go::TestClient_UploadManifest(which is where this new case showed up)The "discovered" issue was that during matching of a
request, we actually normalize the JSON if it's a json content type. That obviously breaks the manifest matching, as the digest only works if the request or response body bytes are exactly the same. This PR extends the "treat this as nontext" to this normalization logic as well.