Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge subscription configuration file values with the supplied subscription config #8422

Merged
merged 5 commits into from
Jun 19, 2024
Merged

Merge subscription configuration file values with the supplied subscription config #8422

merged 5 commits into from
Jun 19, 2024

Conversation

danieljurek
Copy link
Member

@danieljurek danieljurek commented Jun 11, 2024 •
edited
Loading

Tests:

Latest test runs on eng/common PRs:

This includes a breaking change, these PRs fix the break:

@danieljurek danieljurek requested a review from a team as a code owner June 11, 2024 19:13
@danieljurek danieljurek self-assigned this Jun 11, 2024
@danieljurek danieljurek added the Central-EngSys This issue is owned by the Engineering System team. label Jun 11, 2024
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

This was referenced Jun 11, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

This was referenced Jun 17, 2024
Merged
Merged
Merged
Merged
danieljurek added a commit to Azure/azure-sdk-for-js that referenced this pull request Jun 17, 2024
@danieljurek
SubscriptionConfigurationFilePath -> SubscriptionConfigurationFilePat…
13d26a6 
…hs (#30082)

Needed for Azure/azure-sdk-tools#8422
danieljurek added a commit to Azure/azure-sdk-for-js that referenced this pull request Jun 17, 2024
@azure-sdk @danieljurek
Sync eng/common directory with azure-sdk-tools for PR 8422 (#30006)
9488fe4 
Sync eng/common directory with azure-sdk-tools for PR
Azure/azure-sdk-tools#8422 See [eng/common
workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow)

---------

Co-authored-by: Daniel Jurek <[email protected]>
@danieljurek danieljurek enabled auto-merge (squash) June 17, 2024 23:28
@danieljurek danieljurek merged commit 296a188 into main Jun 19, 2024
8 checks passed
@danieljurek danieljurek deleted the djurek/sub-config-files-merge branch June 19, 2024 06:19
@maorleger maorleger mentioned this pull request Feb 4, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benbp benbp benbp left review comments

@weshaggard weshaggard weshaggard approved these changes

Assignees

@danieljurek danieljurek

Labels
Central-EngSys This issue is owned by the Engineering System team.
Projects
Azure SDK EngSys 🤖🧠
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@danieljurek @azure-sdk @benbp @weshaggard