-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use DOTNET_ROLL_FORWARD: 'Major' for test-proxy #8373
Conversation
The following pipelines have been queued for testing: |
@scbedd are we not using the single exe version in our pipelines where this shouldn't be an issue? |
Only |
While I'm not opposed to this fix, I generally don't like force roll forward over majors. Could we also fix this issue by switching to the single exe for those not using it currently? |
We could put this behind a parameter that defaults to |
I don't think that is necessary but do you know why we cannot use the single exe for cpp? |
Chatted w/ @weshaggard -- This can merge today. Wes' concerns include the fact that over time major version changes in frameworks can lead to breaks. I opened #8387 to track having an eng/common YAML which installs the standalone exe. |
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#8373 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) Co-authored-by: Daniel Jurek <[email protected]>
The macos-14 agent does not currently include .NET 6.x: https://github.com/actions/runner-images/blob/main/images/macos/macos-14-Readme.md
Setting this variable ensures that test-proxy will run in environments which have later major versions of .NET Core.