Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use DOTNET_ROLL_FORWARD: 'Major' for test-proxy #8373

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

danieljurek
Copy link
Member

@danieljurek danieljurek commented Jun 3, 2024

The macos-14 agent does not currently include .NET 6.x: https://github.com/actions/runner-images/blob/main/images/macos/macos-14-Readme.md

.NET Core SDK: 7.0.102, 7.0.202, 7.0.306, 7.0.409, 8.0.101, 8.0.204, 8.0.300

Setting this variable ensures that test-proxy will run in environments which have later major versions of .NET Core.

@danieljurek danieljurek requested a review from a team as a code owner June 3, 2024 21:17
@danieljurek danieljurek self-assigned this Jun 3, 2024
@danieljurek danieljurek requested a review from scbedd June 3, 2024 21:21
@danieljurek danieljurek added the Central-EngSys This issue is owned by the Engineering System team. label Jun 3, 2024
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@weshaggard
Copy link
Member

@scbedd are we not using the single exe version in our pipelines where this shouldn't be an issue?

@scbedd
Copy link
Member

scbedd commented Jun 4, 2024

@scbedd are we not using the single exe version in our pipelines where this shouldn't be an issue?

Only java and cpp currently use the tool in pipeline, but it is used yes.

@weshaggard
Copy link
Member

While I'm not opposed to this fix, I generally don't like force roll forward over majors. Could we also fix this issue by switching to the single exe for those not using it currently?

@danieljurek
Copy link
Member Author

We could put this behind a parameter that defaults to false

@weshaggard
Copy link
Member

We could put this behind a parameter that defaults to false

I don't think that is necessary but do you know why we cannot use the single exe for cpp?

@danieljurek
Copy link
Member Author

Chatted w/ @weshaggard -- This can merge today. Wes' concerns include the fact that over time major version changes in frameworks can lead to breaks.

I opened #8387 to track having an eng/common YAML which installs the standalone exe.

danieljurek added a commit to Azure/azure-sdk-for-js that referenced this pull request Jun 7, 2024
@danieljurek danieljurek enabled auto-merge (squash) June 7, 2024 16:06
@danieljurek danieljurek merged commit e9db37b into main Jun 7, 2024
14 checks passed
@danieljurek danieljurek deleted the djurek/test-proxy-dotnet-roll-foward branch June 7, 2024 16:06
JimSuplizio pushed a commit to JimSuplizio/azure-sdk-tools that referenced this pull request Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Central-EngSys This issue is owned by the Engineering System team.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants