Remove SAS token usage from apiview-review-gen #8314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weshaggard
reviewed
May 22, 2024
weshaggard
approved these changes
May 22, 2024
|
Verified this change using pipeline run https://dev.azure.com/azure-sdk/internal/_build/results?buildId=3813927&view=logs&j=d4367c48-f7ef-5b11-a3cc-789c1d007bb1&t=111e49f7-34c2-56f1-14a3-f4495b4ab402 |
praveenkuttappan
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SAS token removal.
The APIView-Sandboxing variable group only has two SAS tokens in it, apiview-originals-sas and apiview-staging-originals-sas. The apiview-staging-originals-sas was setup, but ultimately never used, and the only use of apiview-originals-sas is being removed in this PR. In theory, the variable group can be removed once we know which pipelines it's linked to.
The above being said, APIView-Sandboxing isn't the only VG with apiview-originals-sas in it.