Remove SAS token from GitHubIO blob storage docs publish #8288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JimSuplizio
requested review from
konrad-jamrozik,
weshaggard and
benbp
as code owners
|
The following pipelines have been queued for testing: |
danieljurek
reviewed
May 17, 2024
danieljurek
approved these changes
May 17, 2024
This was referenced May 17, 2024
JimSuplizio
added a commit
to Azure/azure-sdk-for-js
that referenced
this pull request
May 17, 2024
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#8288 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) Co-authored-by: James Suplizio <[email protected]>
auto-merge was automatically disabled
May 17, 2024 18:16
Pull request was closed
weshaggard
reviewed
May 20, 2024
| azureSubscription: 'Azure SDK Artifacts' | ||
| ScriptType: 'FilePath' | ||
| ScriptPath: ${{ parameters.ScriptPath }} | ||
| ScriptArguments: > | ||
| -AzCopy $(Resolve-Path "$(Build.BinariesDirectory)/azcopy/azcopy_windows_amd64_*/azcopy.exe")[0] |
There was a problem hiding this comment.
Orthogonal but we should probably also remove this azcopy approach given it is already on all the agent machines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHubIO versioned docs are published to blob storage which required the SAS key to write.
As part of this work, I did have to give Storage Blob Data Contributor access to azuresdkdocs to the service principal. This is in the same resource group as azure-sdk-artifacts. The replacement of the SAS usage in the eng/common code was pretty straightforward and the language repositories will continue to work without issue. Once this is in, I'll have to go through each language repository to remove usage of azure-sdk-docs-prod-sas and then I'll be able to remove this from the variable group and, ultimately, the keyvault.
The changes were tested via temporary PR in Java and this is the pipeline run for template which published docs