Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove a duplicate sanitizer from the proxy config #8286

Merged
merged 1 commit into from
May 17, 2024

Conversation

scbedd
Copy link
Member

@scbedd scbedd commented May 16, 2024

Brought to my attention by @chlowell

@scbedd scbedd requested review from mikeharder and benbp as code owners May 16, 2024 23:21
@scbedd scbedd self-assigned this May 16, 2024
Copy link
Member

@benbp benbp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Wonder if a hashset would be useful here.

@scbedd
Copy link
Member Author

scbedd commented May 17, 2024

<I somehow edited your comment instead of responding? somehow?>

Hashsets don't maintain order, which we enforce for simplicity of debugging sanitizers by the users.

I see what you're asking now. I could do it that way, yea. Just...didn't. The hashset value probably wouldn't collide in a way that is useful anyway, as we'd use the ID of the sanitizer as the key, not the regex of it.

@scbedd scbedd merged commit f6ff882 into Azure:main May 17, 2024
16 checks passed
@scbedd scbedd mentioned this pull request Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants