-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate stress cluster to use workload identity #8278
Conversation
eng/common/scripts/stress-testing/stress-test-deployment-lib.ps1
Outdated
Show resolved
Hide resolved
The following pipelines have been queued for testing: |
tools/stress-cluster/chaos/examples/network-stress-example/Chart.lock
Outdated
Show resolved
Hide resolved
The following pipelines have been queued for testing: |
The following pipelines have been queued for testing: |
The following pipelines have been queued for testing: |
command: ["sh", "-c"] | ||
args: | ||
- > | ||
az login --federated-token "$(cat $AZURE_FEDERATED_TOKEN_FILE)" --service-principal -u $AZURE_CLIENT_ID -t $AZURE_TENANT_ID; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is using a file the only real way to share this token?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@weshaggard The file is the implementation method used by AKS for federated auth, so unfortunately yes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did a quick scan and things look reasonable.
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#8278 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) --------- Co-authored-by: Ben Broderick Phillips <[email protected]>
Notes TBD, a couple more edits need to be made (docs, test updates, and some more config deletion). Then I will publish out of draft.