Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate Secret Scanning from Microsoft.Security.Utilities #8140

Merged
merged 19 commits into from
May 13, 2024
Merged

Integrate Secret Scanning from Microsoft.Security.Utilities #8140

merged 19 commits into from
May 13, 2024

Conversation

scbedd
Copy link
Member

@scbedd scbedd commented Apr 23, 2024 •
edited
Loading

lol_parallel_is_the_way

todo:

  • Make the call as to scanning entire repo vs only changed files
  • Better reporting of secret scanner errors
  • Add CLI Integration test which fakes a real test secret and prevents push
  • Additional styling for clarity of communication. Add Line # to detection.

@scbedd scbedd self-assigned this Apr 23, 2024
scbedd added 11 commits April 24, 2024 14:07
@scbedd scbedd marked this pull request as ready for review May 9, 2024 02:18
@scbedd scbedd requested a review from mikeharder as a code owner May 9, 2024 02:18
@scbedd scbedd requested review from benbp and weshaggard May 9, 2024 02:21
@weshaggard
Copy link
Member

FYI @michaelcfanning

@scbedd scbedd merged commit 6e56dc9 into main May 13, 2024
12 checks passed
@scbedd scbedd deleted the integrate-secret-scanning branch May 13, 2024 18:20
@scbedd scbedd mentioned this pull request May 17, 2024
Merged
@scbedd scbedd mentioned this pull request Jun 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benbp benbp benbp approved these changes

@mikeharder mikeharder Awaiting requested review from mikeharder mikeharder is a code owner

@weshaggard weshaggard Awaiting requested review from weshaggard

Assignees

@scbedd scbedd

Labels
None yet
Projects
Azure SDK EngSys 🚢🎉
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@scbedd @weshaggard @benbp