Add indentation handling method in Java ApiView tool #8113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srnagar
approved these changes
Apr 17, 2024
...ava-processor/src/main/java/com/azure/tools/apiview/processor/analysers/JavaASTAnalyser.java
Outdated
Show resolved
Hide resolved
Comment on lines
387
to
399
| // allowed dependencies (in maven-enforcer) | ||
| // if (!mavenPom.getAllowedDependencies().isEmpty()) { | ||
| // addToken(INDENT, new Token(KEYWORD, "allowed-dependencies"), SPACE); | ||
| // addToken(new Token(PUNCTUATION, "{"), NEWLINE); | ||
| // indent(); | ||
| // mavenPom.getAllowedDependencies().stream().forEach(value -> { | ||
| // addToken(INDENT, new Token(TEXT, value, value), NEWLINE); | ||
| // }); | ||
| // unindent(); | ||
| // addToken(INDENT, new Token(PUNCTUATION, "}"), NEWLINE); | ||
| // } | ||
|
|
||
| // close maven |
There was a problem hiding this comment.
Do we need to retain this? Seems like this has been commented out from a long time.
There was a problem hiding this comment.
I'm not really sure, this has been commented out for a while and I'm guessing this is something we just haven't implemented but want to? @JonathanGiles
There was a problem hiding this comment.
yeah, it might as well go for now.
...ava-processor/src/main/java/com/azure/tools/apiview/processor/analysers/JavaASTAnalyser.java
Outdated
Show resolved
Hide resolved
JonathanGiles
approved these changes
Apr 17, 2024
...ava-processor/src/main/java/com/azure/tools/apiview/processor/analysers/JavaASTAnalyser.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
indentedBlockto handle indenting and unindenting a section of tokens rather than relying on the methods indent and unindent to be called before and after. Also changes indentation handling to be based on the indentation level in case we want to offer different indentation size (right now it's always 4 whitespaces). Lastly, added a cache for common indentation levels so they can be reused.