Add polly retry to get artifact URL from DevOps #8112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
praveenkuttappan
added
APIView
Central-EngSys
maririos
reviewed
Apr 17, 2024
| @@ -56,10 +56,25 @@ public async Task<Stream> DownloadPackageArtifact(string repoName, string buildI | |||
|
|
|||
| private async Task<string> getDownloadArtifactUrl(string buildId, string artifactName, string project) | |||
| { | |||
| var pauseBetweenFailures = TimeSpan.FromSeconds(2); | |||
There was a problem hiding this comment.
is this number arbritary? or it has history to it
There was a problem hiding this comment.
2 seconds should be ideally enough to start the delay span. So, it's just arbitrary.
maririos
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Request to get artifact URL is still failing with 404 error. Adding polly retry to get URL.URL is working fine when attempted again.