-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TestProxy] Common Sanitizers #8038
Conversation
Co-authored-by: Charles Lowell <[email protected]>
…e-sdk-tools into add-common-sanitizers
…preparation to release. Need to roll out the ability to deregister sanitizers sooner rather than later
Does the proxy already have a way to deduplicate sanitizers so we don't run all of these twice? If not, I imagine it could compare two sanitizers with hashes of their string parameters |
It does not at this time. We will pay the cost for now. I have another PR in the works that makes sanitizers set/get/remove from a single abstraction class. Doing this hash check there would make the most sense if we do it 👍 |
tools/test-proxy/Azure.Sdk.Tools.TestProxy/Common/SanitizerDictionary.cs
Outdated
Show resolved
Hide resolved
tools/test-proxy/Azure.Sdk.Tools.TestProxy/Common/SanitizerDictionary.cs
Outdated
Show resolved
Hide resolved
tools/test-proxy/Azure.Sdk.Tools.TestProxy/Common/SanitizerDictionary.cs
Outdated
Show resolved
Hide resolved
tools/test-proxy/Azure.Sdk.Tools.TestProxy/Common/SanitizerDictionary.cs
Outdated
Show resolved
Hide resolved
tools/test-proxy/Azure.Sdk.Tools.TestProxy/Common/SanitizerDictionary.cs
Outdated
Show resolved
Hide resolved
tools/test-proxy/Azure.Sdk.Tools.TestProxy/Common/SanitizerDictionary.cs
Outdated
Show resolved
Hide resolved
…itional characters -- to include space, newline, backslash, and comma Co-authored-by: JoshLove-msft <[email protected]>
tools/test-proxy/Azure.Sdk.Tools.TestProxy/Common/SanitizerDictionary.cs
Outdated
Show resolved
Hide resolved
tools/test-proxy/Azure.Sdk.Tools.TestProxy/Common/SanitizerDictionary.cs
Show resolved
Hide resolved
tools/test-proxy/Azure.Sdk.Tools.TestProxy/Store/GitAssetsConfiguration.cs
Outdated
Show resolved
Hide resolved
…iguration.cs Co-authored-by: Ben Broderick Phillips <[email protected]>
Thank you to all the reviewers on this PR: @pvaneck , @JoshLove-msft , @chlowell, @samvaity, and @benbp . Hugely appreciate all your feedback.
|
/check-enforcer evaluate |
This PR moves the test-proxy from a static append-only set of sanitizers, to an actual data structure with proper addition/removal of applied sanitizers.
/Admin/AddSanitizers
orAdmin/AddSanitizer
, an object or list of objects representing the registered sanitizers is now returned to the calling client. These objects contain the base sanitizer properties + theid
of the registered sanitizer./Admin/RemoveSanitizers
which can apply to either the session-level or an individual playback/record session.Observers please add suggestions either in discussion or directly onto the branch.