Use different service connection and az CLI for ACR auth #8015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieljurek
added
the
Central-EngSys
|
The following pipelines have been queued for testing: |
This was referenced Apr 3, 2024
This was referenced Apr 3, 2024
danieljurek
requested review from
konrad-jamrozik,
weshaggard and
benbp
as code owners
weshaggard
approved these changes
Apr 3, 2024
benbp
reviewed
Apr 3, 2024
|
The following pipelines have been queued for testing: |
azure-sdk
added a commit
to Azure/azure-sdk-for-js
that referenced
this pull request
Apr 4, 2024
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#8015 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) --------- Co-authored-by: Daniel Jurek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates docker pulls from internal ACR to use a different service connection and auth strategy.
Example release pipeline: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=3662553&view=logs&j=19b87903-f8bc-5cbb-22d9-4f6eb3469d8e&t=789ec5f9-c426-56bf-c6a5-d85b141abeda
Changes in Java and Python pipelines will require this change: