Call GetDocsMsDevLanguageSpecificPackageInfoFn if it's defined #7951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JimSuplizio
added
Docs
Central-EngSys
JimSuplizio
requested review from
konrad-jamrozik,
weshaggard and
benbp
as code owners
|
The following pipelines have been queued for testing: |
danieljurek
approved these changes
Mar 26, 2024
There was a problem hiding this comment.
Before this change merges, a JS change needs to be made. The two can merge at roughly the same time as long as the PRs merge before docindex runs for the day.
The $GetDocsMsDevLanguageSpecificPackageInfoFn function is now more universally applicable after this change. This is how it should've been to begin with.
This was referenced Mar 26, 2024
azure-sdk
added a commit
to Azure/azure-sdk-for-js
that referenced
this pull request
Mar 26, 2024
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#7951 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) Co-authored-by: James Suplizio <[email protected]>
JimSuplizio
added a commit
to Azure/azure-sdk-for-js
that referenced
this pull request
Mar 26, 2024
…e-Settings.ps1 (#29075) This change is necessary to match change in Update-DocsMsMetadata.ps1 made in [this azure-sdk-tools PR](Azure/azure-sdk-tools#7951). The Get-javascript-DocsMsDevLanguageSpecificPackageInfo function is the implementation of the GetDocsMsDevLanguageSpecificPackageInfoFn. This is something that should have been called all the time but because javascript was the only language using this, Update-DocsMsMetadata.ps1 was only calling this if the packageInfo file's DevVersion was set. Because this needs to be called all the time, if it's defined for a given language, and javascript only needs process if the DevVersion is set, move that check to the implemented function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GetDocsMsDevLanguageSpecificPackageInfoFn pointer was only being called if the DevVersion was set and should have been being called all the time, if the function pointer was defined. The reason for this is because the only language that had the function defined was Javascript and it only needed to be called if the DevVersion was set. As such, the fix to this file is to call it all the time and, for Javascript, the Get-javascript-DocsMsDevLanguageSpecificPackageInfo, needs to be updated to only process if the DevVersion is set.