Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an additional timeout handler for mac-errors #7880

Merged
merged 2 commits into from
Mar 15, 2024
Merged

Add an additional timeout handler for mac-errors #7880

merged 2 commits into from
Mar 15, 2024

Conversation

scbedd
Copy link
Member

@scbedd scbedd commented Mar 15, 2024

Attempts to resolve #7784

@scbedd scbedd requested a review from mikeharder as a code owner March 15, 2024 00:10
mikeharder
mikeharder approved these changes Mar 15, 2024
View reviewed changes
Copy link
Member

@mikeharder mikeharder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I also wonder if we could just retry on any error with "timed out"?

@scbedd
Copy link
Member Author

scbedd commented Mar 15, 2024

LGTM, but I also wonder if we could just retry on any error with "timed out"?

I thought about this. Why not. I'll make the change.

@scbedd scbedd self-assigned this Mar 15, 2024
@scbedd scbedd merged commit d624400 into Azure:main Mar 15, 2024
13 checks passed
@scbedd scbedd mentioned this pull request Mar 16, 2024
Merged
@maorleger maorleger mentioned this pull request Feb 4, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeharder mikeharder mikeharder approved these changes

Assignees

@scbedd scbedd

Labels
None yet
Projects
Azure SDK EngSys 🤖🧠
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test-Proxy git clone not retrying properly
2 participants
@scbedd @mikeharder