Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial Issue Triage was adding needs-team-triage incorrectly #7852

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

JimSuplizio
Copy link
Member

This Issue in azure-sdk-for-java was processed using the new InitialIssueTriage rule and incorrectly had needs-team-triage added to it.

needs-team-triage should only be added in the case of no AzureSdkOwners and no ServiceOwners and is correctly done in that case but there looks to be a stray call to gitHubEventClient.AddLabel(TriageLabelConstants.NeedsTeamTriage); which was after the check to see if needs-team-attention was being added.

@JimSuplizio JimSuplizio added the GitHub Event Processor Anything related to the GitHub Event Processor label Mar 11, 2024
@JimSuplizio JimSuplizio requested a review from jsquire March 11, 2024 16:54
@JimSuplizio JimSuplizio self-assigned this Mar 11, 2024
@JimSuplizio JimSuplizio requested a review from benbp as a code owner March 11, 2024 16:54
@JimSuplizio JimSuplizio enabled auto-merge (squash) March 11, 2024 16:59
@JimSuplizio JimSuplizio merged commit e44708a into Azure:main Mar 11, 2024
15 checks passed
@JimSuplizio JimSuplizio deleted the GitHubEventProcFix branch March 11, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GitHub Event Processor Anything related to the GitHub Event Processor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants