Add dotnet-api product slug to sample metadata script #7842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annelo-msft
requested review from
konrad-jamrozik,
weshaggard and
benbp
as code owners
|
The following pipelines have been queued for testing: |
weshaggard
approved these changes
Mar 8, 2024
This was referenced Mar 8, 2024
azure-sdk
added a commit
to Azure/azure-sdk-for-js
that referenced
this pull request
Mar 8, 2024
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#7842 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) Co-authored-by: Anne Thompson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on offline discussion, we believe
dotnet-apiis the best product slug for System.ClientModel samples added in Azure/azure-sdk-for-net#42369.This is because the BinaryData type, also in the
System.namespace uses thems.service=dotnet-apiandms.subservice=system. These were identified as well in the msprod docs metadata-taxonomies.