Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run publish on failed or succeeded #7810

Merged
merged 5 commits into from
Mar 5, 2024
Merged

Run publish on failed or succeeded #7810

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0b2b606
Run publish on failed or succeeded
benbp Mar 4, 2024
ddf5fdd
Expand agent os string detection
benbp Mar 5, 2024
e6e1375
Check agent job status env var for artifact name detection
benbp Mar 5, 2024
aa5cb59
Add sbomEnabled flag to publish template
benbp Mar 5, 2024
a2f534d
Fix image and artifact name conditional
benbp Mar 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion eng/common/pipelines/templates/steps/publish-1es-artifact.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ steps:
displayName: Set Failed Artifact Name
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my other comment #7758 (comment) I think we can make this one step to set the artifact name.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah excellent


- task: 1ES.PublishPipelineArtifact@1
condition: and(succeeded(), ${{ parameters.CustomCondition }})
condition: and(failedOrSucceeded(), ${{ parameters.CustomCondition }})
Copy link
Member

@scbedd scbedd Mar 4, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
condition: and(failedOrSucceeded(), ${{ parameters.CustomCondition }})
condition: and(succeededOrFailed(), ${{ parameters.CustomCondition }})

Possible nit? Real break? Not certain.

Ref

displayName: 'Publish ${{ parameters.ArtifactName }} Artifacts'
inputs:
artifact: '$(PublishArtifactName)'
Expand Down