Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fault-injector: yet another port fix, also make bodyless requests work again #7792

Merged

Conversation

lmolkova
Copy link
Member

Fixes some issues:

  1. Allows to pass urls in cmd line to ASP.NET Core (settings.IgnoreUnknownArguments = true;)
  2. Allows to use appsettings.json when fault-injector runs as global CLI (ContentRootPath = Directory.GetParent(Assembly.GetExecutingAssembly().Location)?.FullName), stolen from global tool - appsettings.json dotnet/sdk#9730 (comment)
  3. Fixes exception when request without body is being proxied (if (Utils.HasBody(request)))

@lmolkova lmolkova requested a review from a team as a code owner February 29, 2024 20:31
@lmolkova lmolkova changed the title Yet another port fix, also make bodyless requests work again Fault-injector: yet another port fix, also make bodyless requests work again Feb 29, 2024
@lmolkova lmolkova merged commit 481137c into Azure:main Feb 29, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants