Change the way ServiceLabel parses with AzureSdkOwners #7754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JimSuplizio
added
CODEOWNERS Linter
weshaggard
reviewed
Feb 26, 2024
weshaggard
approved these changes
Feb 26, 2024
jsquire
approved these changes
Feb 26, 2024
Co-authored-by: Wes Haggard <[email protected]>
This was referenced Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a change requested by @jsquire for the case where a ServiceLabel only has AzureSdkOwners with no ServiceOwners.
Previously, ServiceLabel required service owners in whatever shape that took (either ServiceOwners/NotInRepo or the block ended in a source path/owner line).
With this change, ServiceLabel still requires service owners unless the block only consists of ServiceLabel and AzureSdkOwners.
To be very clear what this allows, the following is now a valid block:
AzureSdkOwners: @Owner1 @owner2
ServiceLabel: %SomeLabel
This does mean that the owners of CODEOWNERS files, whomever they might actually be, need to pay attention to changes to ensure that if a ServiceLabel requires both AzureSdkOwners and ServiceOwners that they're both there.