-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite HttpFaultInjector to use ILogger and built-in ASP.NET Core logging #7476
Conversation
1638775
to
812ea70
Compare
tools/http-fault-injector/Azure.Sdk.Tools.HttpFaultInjector/appsettings.json
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Thank you!!!
ca726c4
to
ae1cc9c
Compare
@mikeharder I've rebased this change on top of streaming and changed controller to middleware (thanks for the suggestion earlier). LMK if you want to take another too. |
tools/http-fault-injector/Azure.Sdk.Tools.HttpFaultInjector/Program.cs
Outdated
Show resolved
Hide resolved
@lmolkova: I reviewed this again and it LGTM. |
Example: