Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FaultInjector: stream response instead of buffering #7466

Merged
merged 6 commits into from
Jan 25, 2024
Merged

FaultInjector: stream response instead of buffering #7466

merged 6 commits into from
Jan 25, 2024

Conversation

lmolkova
Copy link
Member

@lmolkova lmolkova commented Dec 15, 2023 •
edited
Loading

Fixes #7463

Tried with storage stress tests under load:

  • no new issues
  • OOM no longer happens
  • memory utilization is 10x lower
  • throghput in stress test went up ~5x times

image
(fault-injector is now at 200MB, used to be > 2GB)

@lmolkova lmolkova requested a review from a team as a code owner December 15, 2023 07:45
mikeharder
mikeharder requested changes Jan 13, 2024
View reviewed changes
Copy link
Member

@mikeharder mikeharder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, but I think it breaks upstream response without content-length headers.

tools/http-fault-injector/Azure.Sdk.Tools.HttpFaultInjector/Program.cs Outdated Show resolved Hide resolved
@lmolkova lmolkova force-pushed the fault-injector-streaming branch from a706df7 to 11db45e Compare January 24, 2024 03:00
@lmolkova lmolkova force-pushed the fault-injector-streaming branch from 11db45e to 0f20a20 Compare January 24, 2024 03:08
mikeharder
mikeharder approved these changes Jan 24, 2024
View reviewed changes
Copy link
Member

@mikeharder mikeharder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggested a potential perf improvement, but if you want to merge this PR as-is, I can submit this improvement in another PR.

tools/http-fault-injector/Azure.Sdk.Tools.HttpFaultInjector/Program.cs Show resolved Hide resolved
tools/http-fault-injector/Azure.Sdk.Tools.HttpFaultInjector/Program.cs Show resolved Hide resolved
@mikeharder mikeharder assigned lmolkova and unassigned mikeharder Jan 24, 2024
@lmolkova
Copy link
Member Author

@mikeharder thank you for the review!
I will run the last version with storage stress tests and will merge if everything works fine.

@lmolkova lmolkova merged commit ebca8d6 into Azure:main Jan 25, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeharder mikeharder mikeharder approved these changes

Assignees

@lmolkova lmolkova

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fault injector: fails with OOM because it buffers content
2 participants
@lmolkova @mikeharder