Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure HeaderSanitizers apply to list-value headers #7417

Merged
merged 1 commit into from
Dec 8, 2023
Merged

Ensure HeaderSanitizers apply to list-value headers #7417

merged 1 commit into from
Dec 8, 2023

Conversation

scbedd
Copy link
Member

@scbedd scbedd commented Dec 8, 2023 •
edited
Loading

This was discovered by @mssfang , @billwert , and @samvaity . Example of failure:

"headers": {
  "Cookie": [
    "val1",
    "val2"
  ]
}

We weren't sanitizing val2 in the above construct.

This PR fixes that.

@scbedd scbedd added the Central-EngSys This issue is owned by the Engineering System team. label Dec 8, 2023
@scbedd scbedd self-assigned this Dec 8, 2023
@scbedd scbedd requested a review from mikeharder as a code owner December 8, 2023 22:14
billwert
billwert approved these changes Dec 8, 2023
View reviewed changes
Copy link
Contributor

@billwert billwert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick turnaround!

@scbedd
Copy link
Member Author

scbedd commented Dec 8, 2023

Thanks for the quick turnaround!

It's much simpler when it's something that's pretty solid to test for :D

@scbedd
Copy link
Member Author

scbedd commented Dec 8, 2023

/azp run tools - test-proxy - tests

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@scbedd scbedd merged commit ca624e0 into Azure:main Dec 8, 2023
42 checks passed
@scbedd scbedd mentioned this pull request Mar 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@billwert billwert billwert approved these changes

@mikeharder mikeharder Awaiting requested review from mikeharder mikeharder is a code owner

Assignees

@scbedd scbedd

Labels
Central-EngSys This issue is owned by the Engineering System team.
Projects
Azure SDK EngSys 🚢🎉
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scbedd @billwert