Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CodeownersLinter to 1.0.0-dev.20231120.3 #7324

Merged
merged 1 commit into from
Nov 20, 2023
Merged

Update CodeownersLinter to 1.0.0-dev.20231120.3 #7324

merged 1 commit into from
Nov 20, 2023

Conversation

JimSuplizio
Copy link
Member

The CodeownersLinter had two minor updates:

  1. Added an AKA link into the output, when there's errors, that links to the Linter errors and how to deal with them section of the tool's README doc.
  2. If there's a CODEOWNERS baseline file, but no linting errors, it'll output a warning indicating that if the errors have been fixed that the file should be deleted.

@JimSuplizio JimSuplizio added the CODEOWNERS Linter Anything related to the CODEOWNERS linter label Nov 20, 2023
@JimSuplizio JimSuplizio self-assigned this Nov 20, 2023
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

This was referenced Nov 20, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@JimSuplizio JimSuplizio enabled auto-merge (squash) November 20, 2023 20:18
@JimSuplizio JimSuplizio merged commit d256fe3 into Azure:main Nov 20, 2023
10 checks passed
azure-sdk added a commit to azure-sdk/azure-sdk-for-js that referenced this pull request Nov 20, 2023
@azure-sdk @JimSuplizio
Sync eng/common directory with azure-sdk-tools for PR 7324 (Azure#27851)
9e3a003 
Sync eng/common directory with azure-sdk-tools for PR
Azure/azure-sdk-tools#7324 See [eng/common
workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow)

Co-authored-by: James Suplizio <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weshaggard weshaggard weshaggard approved these changes

@kurtzeborn kurtzeborn Awaiting requested review from kurtzeborn kurtzeborn is a code owner

Assignees

@JimSuplizio JimSuplizio

Labels
CODEOWNERS Linter Anything related to the CODEOWNERS linter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JimSuplizio @azure-sdk @weshaggard