Remove CodeOwnersParser #7307
Merged
Remove CodeOwnersParser #7307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JimSuplizio
added
GitHub Event Processor
kurtzeborn
approved these changes
Nov 16, 2023
|
We should also remove https://github.com/Azure/azure-sdk-tools/blob/main/.github/CODEOWNERS#L33. If only we had a code-owners linter that could catch this :) |
@weshaggard, I didn't forget to update the CODEOWNERS in this PR, I was...um...testing the linter pipeline...yes, that's it! Seriously though, I'll get the CODEOWNERS updated when I create the PR for the updated codeowners-utils README. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CodeOwnersParser is gone, replaced by CodeownersUtils.
github-event-processor's ci.yml file should have been changed to trigger off codeowners-utils changes earlier this week when it was updated but I'd missed that then. It's a non-issue since there were no codeowners-utils changes.