[tsp-client] Code fixes #7202
Merged
[tsp-client] Code fixes #7202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
catalinaperalta
commented
Nov 10, 2023
joheredi
reviewed
Nov 11, 2023
joheredi
reviewed
Nov 11, 2023
| @@ -1,8 +1,8 @@ | |||
| import { mkdir, rm, writeFile, stat, readFile, access } from "node:fs/promises"; | |||
| import { FileTreeResult } from "./fileTree.js"; | |||
| import { mkdir, rm, stat, readFile, access } from "node:fs/promises"; | |||
There was a problem hiding this comment.
does it work if you import from "fs/promises"? without node: just curious, as I'm not used to this notation.
There was a problem hiding this comment.
It does seem to work without it. I'm not sure why this was added for me. I could look into removing it in the future if it's better. Let me know! I'll merge this PR in without that change though
joheredi
reviewed
Nov 11, 2023
joheredi
reviewed
Nov 11, 2023
joheredi
approved these changes
Nov 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR is mainly to improve code style, fix some logic, correct async functions
Fixes #7049
Fixes #7048