Empty package models don't throw error #7200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scbedd
requested review from
konrad-jamrozik,
weshaggard and
benbp
as code owners
|
The following pipelines have been queued for testing: |
This was referenced Oct 27, 2023
mikeharder
approved these changes
Oct 27, 2023
weshaggard
reviewed
Oct 30, 2023
scbedd
added a commit
to Azure/azure-sdk-for-js
that referenced
this pull request
Oct 30, 2023
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#7200 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) Co-authored-by: Scott Beddall (from Dev Box) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On
pythonpypy39platform, this script runs into a weird problem.The linked build isolates the error, along with a bunch of debug output showing where stuff is going wrong.
On this
pypy39platform image, we are getting 2 extra "blank" pkg props. That looks like this for the template project:Here's the thing, these are magically showing up. In the same build that produces this error for review, you can see clearly that the actual
Language-Settings.ps1function that is retrieving the package list, is getting the correct list. It just magically gets another two blank objects. I'm almost positive that we're probably leaking two objects from previous commands, but honestly, I've dug at this for a while and I haven't seen it yet.The fix proves working in this build.