Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[live-test-cleanup] Reduce timeout from infinite to default (60 minutes) #7069

Merged
merged 1 commit into from
Oct 5, 2023
Merged

[live-test-cleanup] Reduce timeout from infinite to default (60 minutes) #7069

merged 1 commit into from
Oct 5, 2023

Conversation

mikeharder
Copy link
Member

  • Pipeline normally runs in 15 minutes, so 60 minutes is plenty of time
  • We should not use infinite timeouts, to avoid blocking build agents indefinitely

@mikeharder
[live-test-cleanup] Reduce timeout from infinite to default (60 minutes)
f561a69 
- Pipeline normally runs in 15 minutes, so 60 minutes is plenty of time
- We should not use infinite timeouts, to avoid blocking build agents indefinitely
@mikeharder mikeharder requested review from benbp and weshaggard October 5, 2023 06:31
@mikeharder mikeharder requested a review from a team as a code owner October 5, 2023 06:31
@mikeharder mikeharder self-assigned this Oct 5, 2023
@benbp
Copy link
Member

benbp commented Oct 5, 2023

I believe in the past we were timing out on large back to back purge operations. But as long as the queue is kept healthy we shouldn't need that (and can always increase timeouts temporarily).

@mikeharder
Copy link
Member Author

I believe in the past we were timing out on large back to back purge operations. But as long as the queue is kept healthy we shouldn't need that (and can always increase timeouts temporarily).

I would even be fine with increasing the timeout permanently to something reasonable like 4 hours or however long you think we might need. Just not infinite.

@mikeharder
Copy link
Member Author

/check-enforcer override

@mikeharder mikeharder merged commit 2ae7fb0 into Azure:main Oct 5, 2023
5 checks passed
@mikeharder mikeharder deleted the test-cleanup-timeout branch October 5, 2023 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benbp benbp benbp approved these changes

@weshaggard weshaggard Awaiting requested review from weshaggard

Assignees

@mikeharder mikeharder

Labels
None yet
Projects
Azure SDK EngSys 🚢🎉
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikeharder @benbp