Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[githubio-linkcheck] Reduce timeout from infinite to 6 hours #7068

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

mikeharder
Copy link
Member

  • Pipeline normally runs in 3 hours, so 6 hours is plenty of time
  • We should not use infinite timeouts, to avoid blocking build agents indefinitely

- Pipeline normally runs in 3 hours, so 6 hours is plenty of time
- We should not use infinite timeouts, to avoid blocking build agents indefinitely
@mikeharder mikeharder requested review from benbp and weshaggard October 5, 2023 06:26
@mikeharder mikeharder requested a review from a team as a code owner October 5, 2023 06:26
@mikeharder mikeharder self-assigned this Oct 5, 2023
@mikeharder
Copy link
Member Author

/check-enforcer override

@mikeharder mikeharder merged commit d6ca872 into Azure:main Oct 5, 2023
5 checks passed
@mikeharder mikeharder deleted the linkcheck-timeout-360 branch October 5, 2023 19:19
@weshaggard
Copy link
Member

Did this cause some particular issue or just something you noticed? Setting this to 0 lets the host agent decide how long to run see https://learn.microsoft.com/en-us/azure/devops/pipelines/process/phases?view=azure-devops&tabs=yaml#timeouts. Not sure if 1ES agents have a fallback timeout.

@mikeharder
Copy link
Member Author

Did this cause some particular issue or just something you noticed? Setting this to 0 lets the host agent decide how long to run see https://learn.microsoft.com/en-us/azure/devops/pipelines/process/phases?view=azure-devops&tabs=yaml#timeouts. Not sure if 1ES agents have a fallback timeout.

Since we are using self-hosted agents, I believe setting timeoutInMinutes: 0 can cause the agents to block indefinitely. There might be another timeout eventually, like 48 hours or something. But I'd much rather have us use some large value like 6 hours or even 12 hours rather than "indefinite".

Here's a hung build I believe was blocking an agent for almost 48 hours until I manually cancelled it:

https://dev.azure.com/azure-sdk/internal/_build/results?buildId=3129547&view=logs&j=a460d732-23aa-5493-a411-cc406067acf8&t=71b47ba2-822c-5669-3297-76bbc5d002b7&l=35

@weshaggard
Copy link
Member

Sounds good. I was just curious of what triggered your interest in updating these.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants