Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stress] Add LockDeletionForDays parameter to set PodDisruptionBudget and cleanup job #7002

Merged
merged 4 commits into from
Sep 22, 2023

Conversation

benbp
Copy link
Member

@benbp benbp commented Sep 21, 2023

Locking

This adds a parameter LockDeletionForDays to the stress deploy script, which will prevent a test and all its pods from being killed for a time period by the kubernetes api server. Possible reasons a pod may be killed:

  1. Node rebalancing/scale down
  2. Node security patch updates
  3. Misc. node evictions and scheduler based pod deletions

It also creates a cron job resource set to delete the pod disruption budget after LockDeletionForDays days, so that evictions can then occur (meaning the test pods won't necessarily be killed, but they will no longer be locked).

Parallel

This updates the parallel jobs feature to use the matrix config instead of a separate addons template. This is both more intuitive and allows for setting different parallel values per scenario (rather than per test).

@benbp benbp added Central-EngSys This issue is owned by the Engineering System team. Stress This issue is related to stress testing, part of our reliability pillar. labels Sep 21, 2023
@benbp benbp self-assigned this Sep 21, 2023
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@benbp benbp force-pushed the benbp/stress-addon-parallel-job-template branch from ec812d6 to c16e1dd Compare September 22, 2023 20:29
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@benbp benbp force-pushed the benbp/stress-addon-parallel-job-template branch from 33308f0 to 37f8b2c Compare September 22, 2023 20:58
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

azure-sdk added a commit to Azure/azure-sdk-for-js that referenced this pull request Sep 22, 2023
Sync eng/common directory with azure-sdk-tools for PR
Azure/azure-sdk-tools#7002 See [eng/common
workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow)

---------

Co-authored-by: Ben Broderick Phillips <[email protected]>
@benbp benbp merged commit b9e245f into Azure:main Sep 22, 2023
14 checks passed
@benbp benbp deleted the benbp/stress-addon-parallel-job-template branch September 22, 2023 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Central-EngSys This issue is owned by the Engineering System team. Stress This issue is related to stress testing, part of our reliability pillar.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants