Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip strong name signing validation for secret cli #6858

Merged
merged 1 commit into from
Aug 28, 2023
Merged

Skip strong name signing validation for secret cli #6858

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions eng/pipelines/templates/stages/archetype-sdk-tool-dotnet.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,9 @@ parameters:
- name: ShouldPublishSymbols
type: boolean
default: true
- name: RequireStrongNames
type: boolean
default: true


variables:
Expand Down Expand Up @@ -79,8 +82,8 @@ stages:
DOTNET_MULTILEVEL_LOOKUP: 0

# This step creates "$(packagesToPublishDir)" directory if it doesn't exist.
# This step is necessary since migration to net6.0. This is because since net6.0,
# in case the "Build and Package" above would not output any packages to this directory,
# This step is necessary since migration to net6.0. This is because since net6.0,
# in case the "Build and Package" above would not output any packages to this directory,
# the "Publish to packages artifact" step below would fail on missing directory.
- pwsh: |
if (!(Test-Path -PathType container "$(packagesToPublishDir)")) {
Expand Down Expand Up @@ -155,9 +158,9 @@ stages:
DOTNET_SKIP_FIRST_TIME_EXPERIENCE: 1
DOTNET_CLI_TELEMETRY_OPTOUT: 1
DOTNET_MULTILEVEL_LOOKUP: 0

- ${{ parameters.TestPostSteps }}

- task: PublishTestResults@2
condition: succeededOrFailed()
inputs:
Expand All @@ -181,6 +184,7 @@ stages:
ExeMatrix: ${{ parameters.StandaloneExeMatrix }}
ShouldPublishExecutables: ${{ parameters.ReleaseBinaries }}
ShouldPublishSymbols: ${{ parameters.ShouldPublishSymbols }}
RequireStrongNames: ${{ parameters.RequireStrongNames }}

- ${{if and(not(eq(length(parameters.DockerDeployments), 0)), ne(variables['Build.Reason'], 'PullRequest'), eq(variables['System.TeamProject'], 'internal'))}}:
- stage: PublishDockerImages
Expand Down
2 changes: 2 additions & 0 deletions tools/secret-management/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,3 +25,5 @@ extends:
template: /eng/pipelines/templates/stages/archetype-sdk-tool-dotnet.yml
parameters:
ToolDirectory: tools/secret-management
# Sodium.Core dependency is not strong name signed. Skip validation in order to sign secret cli.
RequireStrongNames: false