Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix admin logging #6812

Merged
merged 3 commits into from
Aug 18, 2023
Merged

Fix admin logging #6812

merged 3 commits into from
Aug 18, 2023

Conversation

JoshLove-msft
Copy link
Member

Previously logging for admin requests was validating that the upstream request uri header was set, which was incorrect.

@scbedd
Copy link
Member

scbedd commented Aug 18, 2023

/azp run tools - test-proxy - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

scbedd
scbedd approved these changes Aug 18, 2023
View reviewed changes
Copy link
Member

@scbedd scbedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JoshLove-msft JoshLove-msft merged commit a5325e5 into Azure:main Aug 18, 2023
@scbedd scbedd mentioned this pull request Aug 18, 2023
Merged
scbedd added a commit that referenced this pull request Aug 21, 2023
@scbedd
Revert "Update Exception Logging (#6671)"
23f2721 
This reverts commit be8d5b4.

Generating a version of the proxy WITH the logging fixes from #6812 but
without the fixes to stderr output.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scbedd scbedd scbedd approved these changes

@mikeharder mikeharder Awaiting requested review from mikeharder mikeharder is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoshLove-msft @scbedd