Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use breadcrumbfiles associated with each asset, versus shared #6604

Merged
merged 17 commits into from
Jul 28, 2023

Conversation

scbedd
Copy link
Member

@scbedd scbedd commented Jul 27, 2023

See title. This addresses the issues that were temporarily mitigated by this .NET PR.

@scbedd scbedd requested a review from mikeharder as a code owner July 27, 2023 20:01
@scbedd scbedd self-assigned this Jul 27, 2023
@scbedd scbedd added the Asset-Sync Any issues relating to moving test assets out of repos. label Jul 27, 2023
@benbp
Copy link
Member

benbp commented Jul 27, 2023

Is this going to have any conflicts when people upgrade locally? i.e. if the new proxy ignores the existing old breadcrumb file, will it try to overwrite stuff or use different paths? I don't fully understand the "pre-breadcrumb file" behavior.

@scbedd
Copy link
Member Author

scbedd commented Jul 27, 2023

Is this going to have any conflicts when people upgrade locally? i.e. if the new proxy ignores the existing old breadcrumb file, will it try to overwrite stuff or use different paths? I don't fully understand the "pre-breadcrumb file" behavior.

It'll write new ones now. Should be seamless upgrade.

@scbedd
Copy link
Member Author

scbedd commented Jul 27, 2023

/azp run tools - test-proxy - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@scbedd
Copy link
Member Author

scbedd commented Jul 27, 2023

Is this going to have any conflicts when people upgrade locally? i.e. if the new proxy ignores the existing old breadcrumb file, will it try to overwrite stuff or use different paths? I don't fully understand the "pre-breadcrumb file" behavior.

It'll write new ones now. Should be seamless upgrade.

However, thinking about this over the afternoon, this upgrade will require an update of the transition script + documentation. My current plan is to

  1. Get this tested and entirely green and merged.
  2. In the same PR that I bump the version of the proxy in, I'll also update the migration script resources under eng/common/testproxy/transition-script/. We were also asking that I move it under onboarding as well. I may as well knock out all of that at the same time while I touch the script.

@scbedd
Copy link
Member Author

scbedd commented Jul 27, 2023

/azp run tools - test-proxy - tests

@azure-pipelines
Copy link

No commit pushedDate could be found for PR 6604 in repo Azure/azure-sdk-tools

@scbedd
Copy link
Member Author

scbedd commented Jul 27, 2023

/azp run tools - test-proxy - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@scbedd
Copy link
Member Author

scbedd commented Jul 28, 2023

/azp run tools - test-proxy - tests

@azure-pipelines
Copy link

No commit pushedDate could be found for PR 6604 in repo Azure/azure-sdk-tools

@scbedd
Copy link
Member Author

scbedd commented Jul 28, 2023

/azp run tools - test-proxy - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@scbedd
Copy link
Member Author

scbedd commented Jul 28, 2023

No commit pushedDate could be found for PR 6604 in repo Azure/azure-sdk-tools

What does this even mean devops bot!?

@scbedd
Copy link
Member Author

scbedd commented Jul 28, 2023

/azp run tools - test-proxy - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@scbedd
Copy link
Member Author

scbedd commented Jul 28, 2023

/azp run tools - test-proxy - tests

@azure-pipelines
Copy link

No commit pushedDate could be found for PR 6604 in repo Azure/azure-sdk-tools

@scbedd
Copy link
Member Author

scbedd commented Jul 28, 2023

/azp run tools - test-proxy - tests

@azure-pipelines
Copy link

No commit pushedDate could be found for PR 6604 in repo Azure/azure-sdk-tools

@scbedd
Copy link
Member Author

scbedd commented Jul 28, 2023

/azp run tools - test-proxy - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@scbedd scbedd merged commit 72a41da into main Jul 28, 2023
@scbedd scbedd deleted the no-unified-breadcrumb-file branch July 28, 2023 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Asset-Sync Any issues relating to moving test assets out of repos.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants