Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix regression in AZC0004 #656

Conversation

christothes
Copy link
Member

Fixes the regression introduced by #650

@christothes christothes requested a review from AlexanderSher May 29, 2020 13:47
@AlexanderSher
Copy link
Contributor

While you at it, can you please add a test for method that have parameters of similar types but different names, e.g.:

public async Task SomeAsync(int a, CancellationToken cancellationToken = default) { return null; }
public void Some(int b, CancellationToken cancellationToken = default) { }

@christothes christothes merged commit 4ae5f56 into Azure:master May 29, 2020
sima-zhu pushed a commit to sima-zhu/azure-sdk-tools that referenced this pull request Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants