Make x509 certificate script from azure-sdk-for-net common to repos #6543
Conversation
benbp
added
the
Central-EngSys
|
The following pipelines have been queued for testing: |
| Usage: | ||
|
|
||
| ```powershell | ||
| Import-Module -Name eng/scripts/X509Certificate2.psm1 # assumes $PWD is repo root |
There was a problem hiding this comment.
Does this have to be a module? In general we have moved away from modules do to loading issues and just use a script with helper functions. However I guess it was already developed that way and you are just porting it to common so we can leave it as is.
There was a problem hiding this comment.
It was developed that way, but I'm also happy to spend a few minutes turning it into a cmdlet instead.
There was a problem hiding this comment.
A cmdlet is a module right? At any rate I'm OK with this for now and if we hit any issues we can reevaluate.
There was a problem hiding this comment.
I think of top-level scripts as cmdlets
There was a problem hiding this comment.
Modules contain 1 or more cmdlets (or none, actually; could just be type or view data). Scripts can be cmdlets. Modules can be unloaded, and because these are all a bunch of related cmdlets I didn't want a bunch of one-off scripts that are harder to keep in sync. In my experience, I've never had problems with modules. They solved the fundamental problems with snapins.
There was a problem hiding this comment.
We have definitely had issues with module loading and unloading, especially during development of them as you often times need to restart your shell to unload successfully. We also have issues when loading modules in parallel when running steps which causes race conditions and other interesting things. That is why we moved to having a set of shared helper scripts/functions instead of modules. That said if I don't have concerns with keeping this as a module if it is already working well as one.
|
Is there any plan to delete the .net repo script that this replaces, or work items to track it? |
@christothes yes after this is merged I was going to delete the NET repo script. Is this part of people's workflows and/or other documentation that I should update? (e.g. should I leave a redirect note in the net/eng directory, or can I just delete it entirely) |
Thanks! - here are the ones I am aware of |
benbp
force-pushed
the
benbp/cert-scripts
branch
from
4c49c3f to
63d0c0f
Compare
|
The following pipelines have been queued for testing: |
|
@christothes PR for net here. Not all the references are changed because a few services have implemented their own function with the same name. |
benbp
force-pushed
the
benbp/cert-scripts
branch
from
63d0c0f to
1bc4c3c
Compare
|
The following pipelines have been queued for testing: |
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#6543 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) Co-authored-by: Ben Broderick Phillips <[email protected]>
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#6543 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) Co-authored-by: Ben Broderick Phillips <[email protected]>
Copying from https://github.com/Azure/azure-sdk-for-net/blob/main/eng/scripts/X509Certificate2/X509Certificate2.psm1 so that we can share cert generating functionality.
Thanks for the suggestion @conniey