Add recording file location #6517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some tests have a need to parse data out of their recordings. When playback is started for a disk based recording, include a new header x-recording-file-location on the response which points to the recording.
…g, so `Assert.NotNull` will not catch bugs.
billwert
commented
Jul 14, 2023
Comment on lines
+65
to
+67
| [InlineData("recordings/TestStartRecordSimplé_nosave.json", "request-response")] | ||
| [InlineData("recordings/TestStartRecordSimple.json", "")] | ||
| [InlineData("recordings/TestStartRecordSimpl�.json", "")] | ||
| [InlineData("recordings/TestStartRecordSimplé.json", "")] |
There was a problem hiding this comment.
I just noticed this - VS must have "helped." Should this get reverted?
scbedd
reviewed
Jul 14, 2023
scbedd
reviewed
Jul 14, 2023
tools/test-proxy/Azure.Sdk.Tools.TestProxy.Tests/PlaybackTests.cs
Outdated
Show resolved
Hide resolved
scbedd
reviewed
Jul 14, 2023
scbedd
approved these changes
Jul 14, 2023
Co-authored-by: Scott Beddall <[email protected]>
scbedd
approved these changes
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are tests in the Java repo which parse the recording files for various reasons. Add a header on the response of playback start to share that location.
I also noticed that the tests were using the wrong assertion for headers, so I changed it to check for string empty/null. (Even null is unnecessary - could be a test against
String.Emptyif you prefer.)