Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FabricBot] Remove Rule Generator #6512

Merged
merged 1 commit into from
Jul 14, 2023
Merged

Conversation

jsquire
Copy link
Member

@jsquire jsquire commented Jul 14, 2023

Summary

The focus of these changes is to remove the legacy tool that was once used to generate Fabric Bot rules from the code owners files for a repository. This tool has been broken for a couple of years and worked only with the retired FabricBot service API.

Now that FabricBot has been retired, there is no need for retaining this tool.

The focus of these changes is to remove the legacy tool that was once used
to generate Fabric Bot rules from the code owners files for a repository.  This
tool has been broken for a couple of years and worked only with the retired
FabricBot service API.

Now that FabricBot has been retired, there is no need for retaining this tool.
@jsquire jsquire added EngSys This issue is impacting the engineering system. Client This issue points to a problem in the data-plane of the library. labels Jul 14, 2023
@jsquire jsquire added this to the 2023-08 milestone Jul 14, 2023
@jsquire jsquire requested a review from JimSuplizio July 14, 2023 16:07
@jsquire jsquire self-assigned this Jul 14, 2023
@jsquire jsquire requested a review from a team as a code owner July 14, 2023 16:07
@weshaggard
Copy link
Member

We should also delete any associated pipeline once this gets merged.

@jsquire
Copy link
Member Author

jsquire commented Jul 14, 2023

/check-enforcer override

@jsquire jsquire merged commit 1ca0861 into Azure:main Jul 14, 2023
@jsquire jsquire deleted the remove-fabricbot branch July 14, 2023 19:38
@jsquire
Copy link
Member Author

jsquire commented Jul 14, 2023

Good call, @weshaggard. I didn't realize there was one; pipeline tools - ConfigureFabricBot has been deleted.

@konrad-jamrozik
Copy link
Contributor

konrad-jamrozik commented Jul 14, 2023

Just for reference, I attempted this before:

@jsquire
Copy link
Member Author

jsquire commented Jul 14, 2023

Apologies, @konrad-jamrozik. I totally forgot that was a thing!

@konrad-jamrozik
Copy link
Contributor

@jsquire no worries! ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client This issue points to a problem in the data-plane of the library. EngSys This issue is impacting the engineering system.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants