Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support ShouldPublishSymbols param in pipeline and set it to false for tool net-changelog-gen #6384

Merged
merged 2 commits into from
Jun 22, 2023
Merged

Support ShouldPublishSymbols param in pipeline and set it to false for tool net-changelog-gen #6384

merged 2 commits into from
Jun 22, 2023

Conversation

RodgeFu
Copy link
Member

@RodgeFu RodgeFu commented Jun 22, 2023

  • Support ShouldPublishSymbols param in pipeline with default value "true"
  • Set it to false for net-changelog-gen because the tool needs to be PackAsTool and has some native binaries in its dependency which would be complained by the PublishSymbol step for missing BuildId for these native binaries. It's fine to not publish symbols for the tool.

@RodgeFu RodgeFu requested a review from a team as a code owner June 22, 2023 05:10
@RodgeFu RodgeFu requested a review from weshaggard June 22, 2023 05:10
@weshaggard
Copy link
Member

I triggered a publish run at https://dev.azure.com/azure-sdk/internal/_build/results?buildId=2866365&view=logs&j=6d7966cd-0423-5022-78e0-a1ae4dd99f62

@weshaggard weshaggard merged commit 89e5378 into Azure:main Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weshaggard weshaggard weshaggard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RodgeFu @weshaggard