Allow Restore to discard pending changes
#6330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeharder
approved these changes
Jun 13, 2023
…nd allows us to ensure that a new restore will properly discard changes
|
/azp run tools - test-proxy - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
benbp
reviewed
Jun 13, 2023
benbp
approved these changes
Jun 13, 2023
Co-authored-by: Ben Broderick Phillips <[email protected]>
|
/azp run tools - test-proxy - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run tools - test-proxy - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run tools - test-proxy - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original thought is that if you had pending changes, but wanted to swap to a different checked out tag for an
assets.json, you would be prevented from doing so withSo that folks can avoid discarding recordings. However, because a lot of these are running behind a shim or some other surrounding script, folks don't see the proxy output clearly. Because they can't see what's going wrong with the proxy, they don't know what to try next.
This PR will eliminate this scenario.
CC @mssfang @samvaity for FYI