-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added switch to skip sync and generate script call #6305
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't mind having the option that can be used but I'm not sure I exactly understand why it is needed. Aren't the existing scripts already calling sync and generate? If so, why wouldn't they just let the process script handle that.
In any case the biggest value is to have a common script to parse the tspconfig and create/update the tsp-location file. So as long as we not duplicating that and parsing the tspconfig in any other place I'm good with this.
Looks like your branch is missing the latest changes from your other PR #6293, so to fix the pipeline you will need to rebase your new changes on top of those older ones. |
* add line offering additional detail * remove extraneous newline
* Add new project `assets-maintenance-tool`. Implement `scan` functionality within. `backup` and `cleanup` still to come. * Add integration tests for new assets-maintenance tool. * Move original `asset-sync` powershell proto script into `tools/assets-automation/` folder * Move `eng/scripts/python/assets-automation/` under `tools/assets-automation/assets-reporting/` * Add ci.yml and tests.yml to invoke integration tests against the azure-sdk-assets-integration Co-authored-by: Konrad Jamrozik <[email protected]>
@weshaggard , |
The following pipelines have been queued for testing: |
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#6305 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) --------- Co-authored-by: raychen <[email protected]>
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#6305 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) --------- Co-authored-by: raychen <[email protected]>
@raych1 how would they know which projects to invoke the dotnet build command on? Mostly I want to avoid needing to read the tspconfig.yaml file directly in any other places. |
Per the agreement with @m-nash, adding this switch in
Process
script to be used by dotnet automation script.With this switch, dotnet can keep most of current script code when adopting new common scripts. Dotnet would also keep using
dotnet build /t:GenerateCode
to generate sdk code.In CI pipeline we have consistent experience,
TypeSpec-Project-Process.ps1
would be called by each language automation script to interact withtspconfig.yaml
and create/updatetsp-location.yaml
.@weshaggard , can you review?