Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Few update on common process script #6250

Merged
merged 7 commits into from
May 31, 2023
Merged

Few update on common process script #6250

merged 7 commits into from
May 31, 2023

Conversation

raych1
Copy link
Member

@raych1 raych1 commented May 29, 2023

  • Revert change of TypeSpecProjectDirectory path match as it's used to load tspconfig firstly
  • Stop execution if returning failure after call sync script
  • Add repo variable assignment in local path scenario

//CC: @weshaggard

@raych1 raych1 self-assigned this May 29, 2023
@weshaggard weshaggard mentioned this pull request May 30, 2023
Merged
@weshaggard
Copy link
Member

To fix the sync pipeline you need to go back and follow the instructions in #6222 to get your earlier change synced.

weshaggard
weshaggard approved these changes May 30, 2023
View reviewed changes
Copy link
Member

@weshaggard weshaggard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion otherwise looks good but please resolve the CI issues from not syncing your previews PR. Please use the workflow process for the eng/common changes to sync to all the other repos.

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

This was referenced May 31, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
azure-sdk added a commit to Azure/azure-sdk-for-js that referenced this pull request May 31, 2023
@azure-sdk @raych1
Sync eng/common directory with azure-sdk-tools for PR 6250 (#26059)
48131b5 
Sync eng/common directory with azure-sdk-tools for PR
Azure/azure-sdk-tools#6250 See [eng/common
workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow)

---------

Co-authored-by: raychen <[email protected]>
@raych1
Copy link
Member Author

raych1 commented May 31, 2023

@weshaggard , should I merge this PR manually or it would be merged automatically? But I don't see auto-merge is appended to this PR.

@weshaggard
Copy link
Member

@weshaggard , should I merge this PR manually or it would be merged automatically? But I don't see auto-merge is appended to this PR.

Yes the auto-merge label no longer works so we need to manually merge these for now.

@weshaggard weshaggard merged commit 1672615 into main May 31, 2023
@weshaggard weshaggard deleted the user/raych1/revert-change branch May 31, 2023 15:11
@raych1 raych1 linked an issue Jun 1, 2023 that may be closed by this pull request
TypeSpec SDK generation common scripts implementation #6144
Closed
minhanh-phan pushed a commit to minhanh-phan/azure-sdk-for-js that referenced this pull request Jun 12, 2023
@azure-sdk @raych1 @minhanh-phan
Sync eng/common directory with azure-sdk-tools for PR 6250 (Azure#26059)
066d68e 
Sync eng/common directory with azure-sdk-tools for PR
Azure/azure-sdk-tools#6250 See [eng/common
workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow)

---------

Co-authored-by: raychen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weshaggard weshaggard weshaggard approved these changes

@konrad-jamrozik konrad-jamrozik Awaiting requested review from konrad-jamrozik

@benbp benbp Awaiting requested review from benbp

Assignees

@raych1 raych1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeSpec SDK generation common scripts implementation
3 participants
@raych1 @weshaggard @azure-sdk